Integrated: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected
SendaoYan
syan at openjdk.org
Mon Apr 29 17:53:09 UTC 2024
On Fri, 26 Apr 2024 03:32:25 GMT, SendaoYan <syan at openjdk.org> wrote:
> Hi,
>
> The curl command lack of "-L" option, cause download file fail, the size of download file is empty.
>
> curl download fail without `-L`:
> ```log
>> rm -rf jmh-core-1.37.jar ; curl -O --fail https://maven.aliyun.com/repository/public/org/openjdk/jmh/jmh-core/1.37/jmh-core-1.37.jar ; ls -lh jmh-core-1.37.jar ; du -sh jmh-core-1.37.jar
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
> -rw-rw-r-- 1 yansendao yansendao 0 Apr 26 17:37 jmh-core-1.37.jar
> 0 jmh-core-1.37.jar
>
>
> curl download success with `-L`:
>
>> rm -rf jmh-core-1.37.jar ; curl -OL --fail https://maven.aliyun.com/repository/public/org/openjdk/jmh/jmh-core/1.37/jmh-core-1.37.jar ; ls -lh jmh-core-1.37.jar ; du -sh jmh-core-1.37.jar
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
> 100 540k 100 540k 0 0 1097k 0 --:--:-- --:--:-- --:--:-- 1097k
> -rw-rw-r-- 1 yansendao yansendao 541K Apr 26 17:38 jmh-core-1.37.jar
> 544K jmh-core-1.37.jar
>
>
>
> Only change devkit shell script, the risk is low.
This pull request has now been integrated.
Changeset: eb88343f
Author: SendaoYan <syan at openjdk.org>
Committer: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/eb88343fb763ee89010b7a9879638152decc6892
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
8331164: createJMHBundle.sh download jars fail when url needed to be redirected
Reviewed-by: erikj, shade
-------------
PR: https://git.openjdk.org/jdk/pull/18965
More information about the build-dev
mailing list