RFR: 8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc [v3]
Magnus Ihse Bursie
ihse at openjdk.org
Tue Apr 30 12:49:11 UTC 2024
On Tue, 30 Apr 2024 12:33:19 GMT, Joachim Kern <jkern at openjdk.org> wrote:
>> I don't think leaving out `-std=c++14` for AIX is a good solution.
>
> I got it. And what about simply disabling the `__STRICT_ANSI__` with
> `CFLAGS_OS_DEF_JVM="-DAIX -D_LARGE_FILES -U__STRICT_ANSI__"` in flags-cflags.m4 for AIX. This worked too. The build is fine.
So what you are saing is basically replacing
CFLAGS_OS_DEF_JVM="-DAIX -Dalloca'(size)'=__builtin_alloca'(size)' -D_LARGE_FILES"
```
with
CFLAGS_OS_DEF_JVM="-DAIX -D_LARGE_FILES -U__STRICT_ANSI__"
```
?
Yeah, that'll work, I guess. "strict ansi" sounds like a problematic thing to have enabled, and that it is added by `-std=c++14` sounds close to a bug in my ears. So a "workaround" where this is disabled seem reasonable.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1584754261
More information about the build-dev
mailing list