RFR: 8331020: Assign LANG to C++ for Windows code that uses C++
Magnus Ihse Bursie
ihse at openjdk.org
Tue Apr 30 14:10:06 UTC 2024
On Tue, 30 Apr 2024 13:53:11 GMT, Julian Waters <jwaters at openjdk.org> wrote:
> I switched it back to LANG since in the original change you switched it to LINK_TYPE from LANG after one of my objections. I had since retracted that objection and have been feeling bad about it. Have you since changed your mind about LANG vs LINK_TYPE in that time?
Yes, I have changed my mind.
I think your objection back then was valid; I created an argument which implied a wider scope than it really delivered, with some vague hand-waving about future extensions. It is better to be more concrete here and now, and rename the parameter if we ever add more meaning to it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18927#issuecomment-2085433698
More information about the build-dev
mailing list