RFR: 8335880: More troubleshooting tips around windows space in path [v3]
Magnus Ihse Bursie
ihse at openjdk.org
Mon Aug 5 12:46:33 UTC 2024
On Tue, 16 Jul 2024 23:20:03 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html
>>
>> People were confused on a few details around fixing windows space names, including:
>> 1. setshortname can report confusing error message when the directory is in use
>> 2. Many directories can have names set but only Microsoft Visual Studio and Windows Kits need them
>>
>> Also adds some notes about `jdk` being the exploded image while `images/jdk` is the actual image.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>
> Update html
doc/building.md line 28:
> 26: 4. Verify your newly built JDK: \
> 27: `./build/*/images/jdk/bin/java -version` \
> 28: Note the built JDK is at `/images/jdk` instead of `/jdk`.
I'm not sure this is really helpful, or at least not in this place and form. Can we move the changes related to how to distinguish a full JDK image from a "partial JDK"/"exploded image" to a separate issue?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20197#discussion_r1704057102
More information about the build-dev
mailing list