RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v2]

[Magnus Ihse Bursie]

On Fri, 26 Jul 2024 19:40:24 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> This proposed change would move the native objects required for NIO file interaction from the libnio native library to the libjava native library on Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8337143: Move natives to <platform>/native/libjava/nio/{ch,fs} as a function of their original location in libnio

make/modules/java.base/lib/CoreLibraries.gmk line 57:

> 55:     OPTIMIZATION := HIGH, \
> 56:     EXTRA_HEADER_DIRS := \
> 57:         libnio/ch, \

This will introduce a source code dependency from libjava to libnio. It might be the correct thing to do, but I just want to highlight this. 

Maybe the libnio/ch code also should move to libjava? Or, perhaps at least the header files. Conceptually, I'd feel better about having a dependency on libnio as a "downstream" library on libjava source code, than the other way around.

make/modules/java.base/lib/CoreLibraries.gmk line 71:

> 69:         -framework Foundation \
> 70:         -framework SystemConfiguration, \
> 71:     LIBS_windows := advapi32.lib ole32.lib shell32.lib version.lib mswsock.lib ws2_32.lib, \

Please keep libraries alphabetically sorted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1704283438
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1704283936