RFR: 8338304: clang on Linux - check for lld presence after JDK-8333189

[Erik Joelsson]

On Wed, 14 Aug 2024 10:49:27 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> After [JDK-8333189](https://bugs.openjdk.org/browse/JDK-8333189) I get now this build error (when using clang on Linux) :
> `clang: error: invalid linker name in argument '-fuse-ld=lld'`
> We  should better check for lld in the configure process if it is required with clang .

make/autoconf/flags-ldflags.m4 line 76:

> 74:       BASIC_LDFLAGS="-fuse-ld=lld -Wl,--exclude-libs,ALL"
> 75:       # Linux/clang toolchain needs now lld on the system to work
> 76:       UTIL_REQUIRE_PROGS(LLD, lld)

I would suggest a more concise comment and moving it up a line as the parameter forcing the use of lld is right there.

Suggestion:

      # Clang needs the lld linker to work correctly
      BASIC_LDFLAGS="-fuse-ld=lld -Wl,--exclude-libs,ALL"
      UTIL_REQUIRE_PROGS(LLD, lld)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20579#discussion_r1716854701