RFR: 8338402: GHA: some of bundles may not get removed

[Zdenek Zambersky]

On Wed, 14 Aug 2024 14:46:42 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Some of bundles may not get removed. This is follows [JDK-8336928](https://bugs.openjdk.org/browse/JDK-8336928). Problem does not always show up, so I have not seen it in my test runs, but since then I have seen some GHA runs affected by this.
>> 
>> **Details:**
>> Turns out, that call to list artifacts is by default limited to first 30 artifacts. GHA of openjdk currently produces 75 artifacts of which 10 are bundles (built jdk). Problem happens if build on some platform takes too long and enough test results (other platforms) got uploaded in meantime. Bundle can then be shifted down in list and not fall into list of first 30 artifacts. Problem can be fixed by increasing per_page limit ([API allows up to 100](https://docs.github.com/en/rest/actions/artifacts?apiVersion=2022-11-28#list-workflow-run-artifacts)).
>> 
>> **Testing:**
>> GHA: OK (see [artifacts in summary tab](https://github.com/zzambers/jdk/actions/runs/10373518734#artifacts))
>
> Looks good, but the 75 current artifacts looks dangerously close to the 100 limit. We'll have to try to keep in mind that if we continue increase the number of artifacts, we might have to replace this with a series of repeated calls.

@magicus thanks

Fortunately bundles usually tend to be at beginning of the list (it was usually just one long running build causing problems). So if number of artifacts would be slightly over the limit, it should be unlikely to cause problems, though possible.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20585#issuecomment-2289054822