RFR: 8282944: GHA: Add Alpine Linux x86_64 pre-integration check [v9]
George Adams
gdams at openjdk.org
Mon Aug 19 09:44:04 UTC 2024
On Fri, 16 Aug 2024 11:52:25 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> George Adams has updated the pull request incrementally with one additional commit since the last revision:
>>
>> build entire JDK rather than hotspot
>
>> Tangentially, I think we should start thinking about extended workflows that are not run by default PR-triggers, so you could potentially run them if you wanted for Alpine-specific fixes. This would making the decisions like this rather easy.
>
> I agree, we should really add that functionality. Then, as you say, it would be a no-brainer to add Alpine as an opt-in build and/or build+test.
>
> If you are hesitant as well about adding this, maybe this is something we should prioritize before accepting this. (And then only accepting this as a non-default option.)
>
> It might be so simple as to not list it in the `default` field of the platform selection part.
>
> @gdams Maybe you can test that? Revert line 39 in main.yml, and start the test manually and specify alpine as a target.
>
> If that works fine, we can add some way for users to set their own defaults by setting a GHA environment/repository variable. (Either an "JDK_EXTRA_TARGETS" to just appent more to the default, or a "JDK_TARGETS" to completely override, or both.)
@magicus I think I've got this working correctly now. If users choose to they can run alpine testing by default by following https://wiki.openjdk.org/display/skara/testing#Testing-Conditionallyenable/disablebuildsandtests or run it manually by triggering the `workflow_dispatch` but by default Alpine will not run
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20577#issuecomment-2296127572
More information about the build-dev
mailing list