RFR: 8329816: Add SLEEF version 3.6.1 [v3]

Hamlin Li mli at openjdk.org
Thu Aug 29 13:55:21 UTC 2024


On Thu, 29 Aug 2024 12:22:32 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> ```
> ${JDK_ROOT}/src
>   |-- jdk.incubator.vector/linux/native/libsleef
>       |-- README.md
>       |-- upstream/ 
>            |-- ... # original sleef source (trimmed or not)
>       |-- generated/
>            |-- misc.h
>            |-- sleefinline_advsimd.h
>            |-- sleefinline_rvvm1.h
>            |-- sleefinline_sve.h
>   |-- jdk.incubator.vector/linux/legal/libsleef.md
> ```

Thanks, this is much better.

> Furthermore, despite what Erik said above, I would really, really like to not have a stand-alone shell script mixed in with the spleef sources. Instead, we should treat updating the generated spleef sources as any other build-related activities, that is, we should have a build target for that.
> ...
> There are two slightly different nuances on how we handle these dependencies.

I'm ok too with either of solutions.
Only reminding is that we should treat sleef build/source-generation as a blackbox.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19185#issuecomment-2317727274


More information about the build-dev mailing list