RFR: 8329816: Add SLEEF version 3.6.1

[Hamlin Li]

On Fri, 30 Aug 2024 10:59:55 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Basically, under the `$(eval $(call SetupJdkLibrary, BUILD_LIBVECTORMATH` call, you add the line:
> 
> ```
>     EXTRA_SRC := libsleef/generated, \
> ```
> 
> and that should be it. 

Thanks!

> However, I see that you also manipulate compiler flags for individual files. I don't know if that is still needed, or can be removed. Or, conversely, if additional files will need the special flags.

OK, let's have discussion in that pr for further details later.

>> make/UpdateSleefSource.gmk line 105:
>> 
>>> 103: TARGETS := $(sleef_native_build)
>>> 104: 
>>> 105: $(eval $(call SetupExecute, sleef_cross_config, \
>> 
>> Not sure if it's still necessary or right to run the 2 steps build the second time, when native and cross-compilation are the same, e.g. build sve for aarch64 on an aarch64 machine.
>
> As the documentation says, the update make target only supports cross-compilation. I based this on the shell script created by Mikael, but I guess his reasoning for doing it that way is the same as mine: When an update is needed, you are going to have to do it for all supported platforms, and hence it is easier to cross-compile it to all targets.
> 
> Since updating is a very uncommon operation, I prefer to keep the makefile simple.

I see, make sense to me.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20781#issuecomment-2320895996
PR Review Comment: https://git.openjdk.org/jdk/pull/20781#discussion_r1738445738