RFR: 8329816: Add SLEEF version 3.6.1 [v4]
Erik Joelsson
erikj at openjdk.org
Fri Aug 30 16:57:20 UTC 2024
On Fri, 30 Aug 2024 16:03:19 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to optimize vector math operations by leveraging the SLEEF library. For legal reasons the actual contribution of the SLEEF files needs to be handled separately.
>>
>> This is a new attempt at solving [JDK-8329816](https://bugs.openjdk.org/browse/JDK-8329816); the original attempt is here: https://github.com/openjdk/jdk/pull/19185. This PR is based on the discussions on how to move forward that was held in that original PR.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>
> README fixes
Can confirm that I get no diff when running the update target now.
src/jdk.incubator.vector/linux/native/libsleef/README.md line 31:
> 29: `src/jdk.incubator.vector/linux/native/libsleef/upstream`.
> 30:
> 31: The libsleef source code do not follow the JDK whitespace rules as enforced by
Suggestion:
The libsleef source code does not follow the JDK whitespace rules as enforced by
src/jdk.incubator.vector/linux/native/libsleef/README.md line 32:
> 30:
> 31: The libsleef source code do not follow the JDK whitespace rules as enforced by
> 32: jcheck. You will need to remove trailing whitespaces, and expand tabs to 8
Suggestion:
jcheck. You will need to remove trailing whitespace, and expand tabs to 8
-------------
PR Review: https://git.openjdk.org/jdk/pull/20781#pullrequestreview-2273050769
PR Review Comment: https://git.openjdk.org/jdk/pull/20781#discussion_r1739118570
PR Review Comment: https://git.openjdk.org/jdk/pull/20781#discussion_r1739119374
More information about the build-dev
mailing list