RFR: 8329816: Add SLEEF version 3.6.1 [v5]
Hamlin Li
mli at openjdk.org
Fri Aug 30 19:51:19 UTC 2024
On Fri, 30 Aug 2024 16:57:18 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to optimize vector math operations by leveraging the SLEEF library. For legal reasons the actual contribution of the SLEEF files needs to be handled separately.
>>
>> This is a new attempt at solving [JDK-8329816](https://bugs.openjdk.org/browse/JDK-8329816); the original attempt is here: https://github.com/openjdk/jdk/pull/19185. This PR is based on the discussions on how to move forward that was held in that original PR.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
>
> - Use "whitespace" as an uncountable noun
>
> Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
> - I suck at English verb forms
>
> Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
I've applied the generated sleef headers to aarch64/riscv64 patches (`Optimize vector math operations with SLEEF`), all good (the so files are built successfully, the tests jdk/incubator/vector/(Double|Float)MaxVectorTests.java run successfully, also output log is correct), although I don't run jmh tests, I think it's fine.
Thanks @magicus @erikj79 for the efficient co-work!
-------------
Marked as reviewed by mli (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20781#pullrequestreview-2273399318
More information about the build-dev
mailing list