RFR: 8345507: Fix build of static launcher
Erik Joelsson
erikj at openjdk.org
Wed Dec 4 17:53:47 UTC 2024
On Wed, 4 Dec 2024 16:23:02 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> Unfortunately, [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480) as checked in does not work.
>
> One of the very last review updates of [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480) was a rename of a make variable. Since this seemed trivial to me, I did not re-test the code after making this change. That was my second mistake. My first mistake was to not discover that this variable was in fact used in another place, so a crucial test never passes and the code does not work.
Marked as reviewed by erikj (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/22551#pullrequestreview-2479480849
More information about the build-dev
mailing list