RFR: 8345744: Use C++ LINK_TYPE with SetupBuildLauncher in StaticLibs.gmk [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Mon Dec 9 21:11:40 UTC 2024
On Mon, 9 Dec 2024 19:33:55 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> Please review following fix for linking static JDK launcher, thanks.
>>
>> - Set LINK_TYPE to C++ when building the static launcher to make sure LDCXX instead of LD is used for linking.
>>
>> - Remove -l:libstdc++. For linux, -static-libstdc++ is already set in STATIC_STDCXX_FLAGS. See https://github.com/openjdk/jdk/blob/e0d639878346946d0627a57b0eeb0cac8ca533fc/make/autoconf/lib-std.m4#L50.
>>
>> See more details in https://bugs.openjdk.org/browse/JDK-8345744.
>
> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove -lstdc++ and STANDARD_LIBS, based on magicus' comment.
Looks good now!
-------------
Marked as reviewed by ihse (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22624#pullrequestreview-2490090399
More information about the build-dev
mailing list