RFR: 8345590: AIX 'make all' fails after JDK-8339480

Christoph Langer clanger at openjdk.org
Thu Dec 12 16:22:36 UTC 2024


On Thu, 12 Dec 2024 14:14:18 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> On AIX we after [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480) into this error
> 
> 
> make all
> Building target 'all' in configuration '/open_jdk/jdk/build_aix'
> Creating 1 test executable file(s) for BUILD_LIBTEST_JTREG_EXECUTABLES
> StaticLibs.gmk:107: *** Unsupported platform. Stop.
> make/Main.gmk:457: recipe for target 'static-launcher' failed
> gmake[2]: *** [static-launcher] Error 1
> 
> 
> For now, do not build the  static-jdk-image  part on AIX.

Looks pragmatic for now. One minor nit about indentation.

make/Main.gmk line 1314:

> 1312: # all-images builds all our deliverables as images.
> 1313: ifeq ($(call isTargetOs, aix), true)
> 1314: all-images: product-images test-image all-docs-images

I think you should indent the all-images line like in the other places.

-------------

Changes requested by clanger (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22713#pullrequestreview-2500152958
PR Review Comment: https://git.openjdk.org/jdk/pull/22713#discussion_r1882468714


More information about the build-dev mailing list