RFR: 8346669: Increase abstraction in SetupBuildLauncher and remove extra args

[Magnus Ihse Bursie]

On Thu, 19 Dec 2024 21:57:38 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> We need to raise the abstraction of the SetupBuildLauncher API, to prepare for static launchers. We should specify the desired outcome, not what flags we should add. This can be seen as the last part of [JDK-8141444](https://bugs.openjdk.org/browse/JDK-8141444) (9 years later).
>> 
>> In the process, I am removing EXTRA_JAVA_ARGS which has not been used for a long time. I also removed this part from the launcher itself.
>
> make/common/modules/LauncherCommon.gmk line 162:
> 
>> 160:           -framework ApplicationServices \
>> 161:           -framework Cocoa \
>> 162:           -framework Security, \
> 
> What happened to all of these? Were they never needed?

I don't know. If so, it was a long time ago. 

Hm, maybe it was from when JLI was statically linked. It could actually be that we still need something like:

LIB_aix := $(LIBZ_LIBS), \


Perhaps someone from the AIX team can check this?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22832#discussion_r1893923768