RFR: 8346669: Increase abstraction in SetupBuildLauncher and remove extra args

[Magnus Ihse Bursie]

On Fri, 20 Dec 2024 14:31:04 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> We need to raise the abstraction of the SetupBuildLauncher API, to prepare for static launchers. We should specify the desired outcome, not what flags we should add. This can be seen as the last part of [JDK-8141444](https://bugs.openjdk.org/browse/JDK-8141444) (9 years later).
>> 
>> In the process, I am removing EXTRA_JAVA_ARGS which has not been used for a long time. I also removed this part from the launcher itself.
>
> make/common/modules/LauncherCommon.gmk line 73:
> 
>> 71:   endif
>> 72: 
>> 73:   ifeq ($$($1_MAIN_MODULE), )
> 
> Why was this check removed? Is MAIN_MODULE no longer needed?

It is never overridden. I don't know what would make us override it either, seems just weird.

> make/common/modules/LauncherCommon.gmk line 85:
> 
>> 83: 
>> 84:   ifeq ($(call isTargetOs, windows), true)
>> 85:     ifeq ($$($1_WINDOWS_JAVAW), true)
> 
> WINDOWS_JAVAW sounds a bit clunky. Does just JAVAW work instead? Not really that important, feel free to ignore this if you prefer the existing name

Well, it is only affecting Windows builds. It should really be "CONSOLELESS_ON_WINDOWS" or something like that, but that was even worse. I thought "javaw" was well-known enough to be understood as "consoleless". Note that previously we set this using "CFLAGS_windows := -DJAVAW" so the Windows-only indication was there but in a slightly different way.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22832#discussion_r1894065863
PR Review Comment: https://git.openjdk.org/jdk/pull/22832#discussion_r1894067536