RFR: 8345757: [ASAN] clang17 report 'dprintf' macro redefined [v3]

SendaoYan syan at openjdk.org
Sat Dec 21 03:34:34 UTC 2024


> Hi all,
> File src/java.smartcardio/share/native/libj2pcsc/pcsc.c and src/jdk.crypto.cryptoki/share/native/libj2pkcs11/j2secmod.h generate compile warning `'dprintf' macro redefined` by clang17/llvm17 with fastdebug configure. This PR undefine `dprintf` before define dprintf macro, to avoid deplication macro definition to linux header `/usr/include/bits/stdio2.h`, risk is low.
> 
> Additional testing:
> 
> - [x] build with fastdebug and release configure by gcc14 on linux-x64
> - [x] jtreg tests(include tier1/2/3 etc.) on linux-x64 with release build
> - [x] jtreg tests(include tier1/2/3 etc.) on linux-x64 with fastdebug build
> - [x] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 with release build
> - [x] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 with fastdebug build

SendaoYan has updated the pull request incrementally with one additional commit since the last revision:

  add comments // GNU, POSIX.1-2008

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22630/files
  - new: https://git.openjdk.org/jdk/pull/22630/files/2a1671ac..693953f7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22630&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22630&range=01-02

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/22630.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22630/head:pull/22630

PR: https://git.openjdk.org/jdk/pull/22630


More information about the build-dev mailing list