RFR: 8345757: [ASAN] clang17 report 'dprintf' macro redefined [v3]

[SendaoYan]

On Sat, 21 Dec 2024 16:11:56 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> src/java.smartcardio/share/native/libj2pcsc/pcsc.c line 48:
>> 
>>> 46: #define dprintf3(s, p1, p2, p3) printf(s, p1, p2, p3)
>>> 47: #else
>>> 48: #undef dprintf // GNU, POSIX.1-2008
>> 
>> Shouldn't this be before the `#ifdef J2PSC_DEBUG`?  Otherwise, we'll get the same problem when
>> debugging is enabled.
>
> A more sweeping change would be to rename this dprintf macro to (say) debug_printf, make it
> variadic, and get rid of the various dprintfN variants.  I'm okay with the current approach as an
> unbreak-the-build fix though.

Thanks for the advice. dprintf has been renamed to debug_printf and make it variadic.

>> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/j2secmod.h line 45:
>> 
>>> 43: #define dprintf3(s, p1, p2, p3) printf(s, p1, p2, p3)
>>> 44: #else
>>> 45: #undef dprintf // GNU, POSIX.1-2008
>> 
>> Shouldn't this be before the #ifdef SECMOD_DEBUG? Otherwise, we'll get the same problem when
>> debugging is enabled.
>
> A more sweeping change would be to rename this dprintf macro to (say) debug_printf, make it
> variadic, and get rid of the various dprintfN variants.  I'm okay with the current approach as an
> unbreak-the-build fix though.

Thanks for the advice. dprintf has been renamed to debug_printf and make it variadic.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22630#discussion_r1894739466
PR Review Comment: https://git.openjdk.org/jdk/pull/22630#discussion_r1894739512