RFR: 8346773: Fix unmatched brackets in source files

Erik Joelsson erikj at openjdk.org
Mon Dec 23 14:05:35 UTC 2024


On Mon, 23 Dec 2024 09:45:00 GMT, Qizheng Xing <qxing at openjdk.org> wrote:

> This patch fixes unmatched brackets in some source files.

I can really only review the doc files and the Makefile.

doc/hotspot-unit-tests.md line 175:

> 173: there is no need to have them in error messages. Asserts print only
> 174: compared values, they do not print any of interim variables, e.g.
> 175: `ASSERT_TRUE(val1 == val2 && isFail(foo(8)) || i == 18)` prints only

Looking at this expression, I believe the intention is this.
Suggestion:

`ASSERT_TRUE((val1 == val2 && isFail(foo(8))) || i == 18)` prints only

-------------

PR Review: https://git.openjdk.org/jdk/pull/22861#pullrequestreview-2520648246
PR Review Comment: https://git.openjdk.org/jdk/pull/22861#discussion_r1895785097


More information about the build-dev mailing list