RFR: 8346773: Fix unmatched brackets in source files
Phil Race
prr at openjdk.org
Mon Dec 23 20:33:36 UTC 2024
On Mon, 23 Dec 2024 19:30:56 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> This patch fixes unmatched brackets in some source files.
>
> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/table/resources/oscars.xml line 2:
>
>> 1: <?xml version="1.0" encoding="UTF-8"?>
>> 2: <oscars xmlns:osc-results="http://www.fatdog.com/oscar-results"
>
> Does this change affect the behavior of the associated test(s)?
I was also wondering how this was tested.
> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/table/resources/oscars.xml line 2:
>
>> 1: <?xml version="1.0" encoding="UTF-8"?>
>> 2: <oscars xmlns:osc-results="http://www.fatdog.com/oscar-results"
>
> I can't tell whether anything was changed in this file other than the modification of all the end of
> line indicators. I've no idea whether changing those is appropriate or not, but this file came from
> a 3rd party, so might not be appropriate to change here.
+1 to all of that. This change is un-reviewable.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22861#discussion_r1896100629
PR Review Comment: https://git.openjdk.org/jdk/pull/22861#discussion_r1896100936
More information about the build-dev
mailing list