RFR: 8346773: Fix unmatched brackets in source files [v2]
Kim Barrett
kbarrett at openjdk.org
Tue Dec 24 22:25:41 UTC 2024
On Tue, 24 Dec 2024 20:27:37 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Hmm, apparently this is not run as part of tier 1-3, which I ran in my patch. I wonder how this test is run. And it means this patch needs to be backported to 24.
>
> Only this small piece would be appropriate for backport to 24. I suggest splitting this out into its own bug,
> fixing it in isolation, and backporting that.
The purpose of this Makefile seems to be to build ctw.jar. So far as I can tell, nothing in the JDK uses that jar,
or invokes that Makefile. There are some tests for the ctw component in hotspot/jtreg/testlibrary_tests/ctw. I
think if you ran tier4 testing that you would hit those. Or you could use `TEST=hotspot:hotspot_misc`, or
specify that directory. But those tests don't appear to use that jar. So I think there isn't a test that touches
this Makefile.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22861#discussion_r1896981987
More information about the build-dev
mailing list