RFR: 8345757: [ASAN] clang17 report 'dprintf' macro redefined [v4]

[Valerie Peng]

On Sun, 22 Dec 2024 02:38:31 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> File src/java.smartcardio/share/native/libj2pcsc/pcsc.c and src/jdk.crypto.cryptoki/share/native/libj2pkcs11/j2secmod.h generate compile warning `'dprintf' macro redefined` by clang17/llvm17 with fastdebug configure. This PR rename dprintf to debug_printf and make it variadic, to avoid deplication macro definition to linux header `/usr/include/bits/stdio2.h`, risk is low.
>> 
>> Additional testing:
>> 
>> - [x] build with fastdebug and release configure by gcc14 on linux-x64
>> - [x] jtreg tests(include tier1/2/3 etc.) on linux-x64 with release build
>> - [x] jtreg tests(include tier1/2/3 etc.) on linux-x64 with fastdebug build
>> - [x] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 with release build
>> - [x] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 with fastdebug build
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into jbs8345757
>  - rename dprintf to debug_printf and make it variadic
>  - add comments // GNU, POSIX.1-2008
>  - Merge branch 'openjdk:master' into jbs8345757
>  - 8345757: [ASAN] clang17 report dprintf macro redefined

Looks good.

I've added the noreg-build label to the bug record to indicate that this change is build-only and no regression test.

-------------

Marked as reviewed by valeriep (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22630#pullrequestreview-2522246895
PR Comment: https://git.openjdk.org/jdk/pull/22630#issuecomment-2561507049