Integrated: 8324834: Use _LARGE_FILES on AIX
Magnus Ihse Bursie
ihse at openjdk.org
Thu Feb 1 13:12:06 UTC 2024
On Mon, 29 Jan 2024 11:44:34 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> In the same spirit as [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt the AIX-specific code in hotspot so it uses the well-defined posix `<foo>` functions, instead of `<foo>64`. By setting the define _LARGE_FILES, this will make `<foo>` behave as `<foo>64`, just as _FILE_OFFSET_BITS=64 does on gcc. (Reference: https://www.ibm.com/docs/en/aix/7.1?topic=volumes-writing-programs-that-access-large-files)
>
> In theory, it should not even be necessary to set this, since we only compile for 64-bit AIX platforms, and this is only relevant on 32-bit platforms. But let's add the define anyway, for good measure. It shows at least that we have thought about the matter. :-)
>
> I have not been able to test this on AIX. I hope someone with AIX access can take this for a spin.
>
> The reason I'm doing this is for [JDK-8324539](https://bugs.openjdk.org/browse/JDK-8324539). After both these bugs are fixed, there will be no more `<foo>64` function calls in the code base.
This pull request has now been integrated.
Changeset: 8e451823
Author: Magnus Ihse Bursie <ihse at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/8e45182357f4990c86fd0b711a7a91887945480b
Stats: 21 lines in 4 files changed: 4 ins; 0 del; 17 mod
8324834: Use _LARGE_FILES on AIX
Reviewed-by: erikj, mbaesken
-------------
PR: https://git.openjdk.org/jdk/pull/17611
More information about the build-dev
mailing list