RFR: 8324243: Fix GCC 14 build [v2]

[Magnus Ihse Bursie]

On Fri, 2 Feb 2024 06:35:26 GMT, Sam James <duke at openjdk.org> wrote:

>> This fixes building with GCC 14:
>> * Cherry-pick a fix from Harfbuzz upstream
>> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources
>> 
>> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses
>> -Werror.
>> 
>> The calloc prototype is:
>> 
>> void *calloc(size_t nmemb, size_t size);
>> 
>> 
>> So, just swap the number of members and size arguments to match the prototype, as
>> we're initialising 1 struct of size `sizeof(struct ...)`. GCC then sees we're not
>> doing anything wrong.
>
> Sam James has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - fix whitespace
>  - Revert "harfbuzz: Cherry-pick upstream fix for GCC 14"
>    
>    This reverts commit acdd606c5d818baa783c6529ea58e66a061ec64a.
>  - Conditionally pass -Wno-transposed-calloc-args for bundled harfbuzz

Changes look good from a build perspective, but you need an ok from client as well for java.desktop changes.

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17506#pullrequestreview-1858456679