RFR: 8325194: GHA: Add macOS M1 testing [v4]
George Adams
gdams at openjdk.org
Sun Feb 4 09:04:03 UTC 2024
On Sat, 3 Feb 2024 21:45:27 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> George Adams has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update copyright headers
>
> .github/actions/get-jtreg/action.yml line 66:
>
>> 64: fi
>> 65: # Build JTReg and move files to the proper locations
>> 66: bash make/build.sh --jdk "$JDK"
>
> We did this `JAVA_HOME_17_X64` change for https://github.com/openjdk/jdk/commit/959a61fdd483c9523764b9ba0972f59ca06db0ee, which is partially reverted during upgrade of GH actions. (...and I forgot to revert this hunk, apparently.) I wonder if it would be simpler if we switch back to boot JDK for building jtreg again, which would eliminate this hunk? Might make backports easier too.
>
> I have no strong opinion here, though.
@shipilev updated PTAL
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17694#discussion_r1477222603
More information about the build-dev
mailing list