RFR: 8324243: Fix GCC 14 build [v3]
Julian Waters
jwaters at openjdk.org
Sun Feb 4 15:33:03 UTC 2024
On Sat, 3 Feb 2024 10:07:26 GMT, Sam James <duke at openjdk.org> wrote:
>> This fixes building with GCC 14:
>> * ~Cherry-pick a fix from Harfbuzz upstream~
>> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources
>>
>> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses
>> -Werror.
>>
>> The calloc prototype is:
>>
>> void *calloc(size_t nmemb, size_t size);
>>
>>
>> So, just swap the number of members and size arguments to match the prototype, as
>> we're initialising 1 struct of size `sizeof(struct ...)`. GCC then sees we're not
>> doing anything wrong.
>
> Sam James has updated the pull request incrementally with one additional commit since the last revision:
>
> whitespace
Marked as reviewed by jwaters (Committer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/17506#pullrequestreview-1858460113
More information about the build-dev
mailing list