RFR: 8325163: Enable -Wpedantic on clang [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Mon Feb 5 10:58:17 UTC 2024
> Inspired by (the later backed-out) [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to enable `-Wpedantic` for clang. This has already found some irregularities in the code, like mistakenly using `#import` instead of `#include`. In this patch, I disable warnings for these individual buggy or badly written files, but I intend to post follow-up issues on the respective teams to have them properly fixed.
>
> Unfortunately, it is not possible to enable `-Wpedantic` on gcc, since individual warnings in `-Wpedantic` cannot be disabled. This means that code like this:
>
>
> #define DEBUG_ONLY(code) code;
>
> DEBUG_ONLY(foo());
>
>
> will result in a `; ;`. This breaks the C standard, but is benign, and we use it all over the place. On clang, we can ignore this by `-Wno-extra-semi`, but this is not available on gcc.
Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
FIx dtrace build
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17687/files
- new: https://git.openjdk.org/jdk/pull/17687/files/4de3c446..ffa70af6
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17687&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17687&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/17687.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17687/head:pull/17687
PR: https://git.openjdk.org/jdk/pull/17687
More information about the build-dev
mailing list