RFR: 8321373: Build should use LC_ALL=C.UTF-8 [v3]

Erik Joelsson erikj at openjdk.org
Mon Feb 5 13:38:02 UTC 2024


On Mon, 5 Feb 2024 10:38:26 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> We're currently setting LC_ALL=C. Not all tools will default to utf-8 as their encoding of choice when they see this locale, but use an arbitrarily encoding, which might not properly handle all UTF-8 characters. Since in practice, all our encoding is utf8, we should tell our tools this as well.
>> 
>> This will at least have effect on how Java treats path names including unicode characters.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update copyright year
>  - check for utf-8 first

Marked as reviewed by erikj (Reviewer).

make/autoconf/basic.m4 line 136:

> 134:     fi
> 135:   else
> 136:       AC_MSG_WARN([locale command not not found, using C locale])

Inconsistent indentation here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16971#pullrequestreview-1862818344
PR Review Comment: https://git.openjdk.org/jdk/pull/16971#discussion_r1478262965


More information about the build-dev mailing list