RFR: JDK-8325189: Enable this-escape javac warning in java.base

[Stuart Marks]

On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> After the "this-escape" lint warning was added to javac (JDK-8015831), the base module was not updated to be able to compile with this warning enabled. This PR makes the necessary changes to allow the base module to build with the warning enabled.

Changes in java.util and java.util.concurrent look fine.

There are a startling number of places where `this` is potentially leaked to a subclass. It would be interesting to analyze the pathologies and have a discussion of potential fixes. There may also be compatibility issues with potential fixes (nothing in this PR that I can see) because the behavior can change from the point of view of subclasses.

-------------

Marked as reviewed by smarks (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17692#pullrequestreview-1863853251