RFR: 8325342: Remove unneeded exceptions in compare.sh

Magnus Ihse Bursie ihse at openjdk.org
Tue Feb 6 16:59:03 UTC 2024


Over time, we have been better at addressing inconsistencies in the build, but the exceptions put in place in compare.sh have not been updated to reflect this.

This attempts to make sure we only keep those exceptions that are currently actually needed to verify a reproducible build (the primary usecase for the compare script these days).

I also discovered bugs in the script, where mismatches in a zip file did not make us report a failed comparison. I added extra code to make sure we always set the REGRESSION flag whenever we detect a problem.

-------------

Commit messages:
 - 8325342: Remove unneeded exceptions in compare.sh

Changes: https://git.openjdk.org/jdk/pull/17735/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17735&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8325342
  Stats: 127 lines in 2 files changed: 15 ins; 104 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/17735.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17735/head:pull/17735

PR: https://git.openjdk.org/jdk/pull/17735


More information about the build-dev mailing list