RFR: 8325570: Update to Graphviz 9.0.0
Erik Joelsson
erikj at openjdk.org
Fri Feb 9 19:29:02 UTC 2024
On Fri, 9 Feb 2024 19:02:13 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:
> Graphviz (aka. dotty/dot) is used when building "full" docs, and in particular for creating various module graph images (.svg). This change upgrades the Graphviz version used to 9.0.0 (latest).
>
> In particular, the change:
>
> * Updates the createGraphvizBundle.sh script (currently broken) to build graphviz from source
> * Updates doc/building.{md,html} to reflect the role of Graphviz and Pandoc in the build
> * The version of of the graphviz dependency used when building at Oracle (in jib-profiles.js)
>
> Since, in addition to the changes in this PR itself, the exact version of Graphviz has an effect on the generated images, I have uploaded the docs generated by graphviz 9.0.0 here: https://cr.openjdk.org/~mikael/graphviz-9.0.0/cmp-v1/docs/api/. For baseline the latest jdk23 docs, which uses graphviz 2.38.0, should do the trick: https://download.java.net/java/early_access/jdk23/docs/api/.
>
> For example, picking a random .svg file:
>
> baseline (graphviz 2.38.0): https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/Signature/RefTypeSig-sealed-graph.svg
> new (graphviz 9.0.0): https://cr.openjdk.org/~mikael/graphviz-9.0.0/cmp-v1/docs/api/java.base/java/lang/classfile/Signature/RefTypeSig-sealed-graph.svg
>
>
> Testing: tier1, manual inspection of a few of the generated .svg files
>
> As far as I can tell there are only very minor differences between the old (2.38.0) and new (9.0.0) .svg files. In particular, it seems like the new graphs are ever so slightly (5-10% or so) larger, but otherwise appear to be identical.
Build changes and generator script look good to me. I don't want to be the judge of the difference in svg output.
-------------
Marked as reviewed by erikj (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17794#pullrequestreview-1873062975
More information about the build-dev
mailing list