RFR: JDK-8298405: Support Markdown in Documentation Comments [v6]
Jonathan Gibbons
jjg at openjdk.org
Fri Feb 9 21:20:08 UTC 2024
On Fri, 9 Feb 2024 18:27:59 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java line 201:
>>
>>> 199: }
>>> 200: newline = true;
>>> 201: }
>>
>> I can see clean LF and CRLF, but no FF; was the latter intentional?
>>
>> In any case, we should double-check the generated test output to see if there's anything unexpected.
>
> We've been here, with `\f` before, noting the different handling of `\f` in `javac` and `javadoc`.
>
> My recollection is that it was intentional to drop support for `\f`, thus aligning `javac` and `javadoc` behavior, and to normalize handling of the newline sequences, translating them to `\n`.
> In any case, we should double-check the generated test output to see if there's anything unexpected.
verified tests pass and no change in generated JDK API docs
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1484812046
More information about the build-dev
mailing list