RFR: 8325950: Make sure all files in the JDK pass jcheck
Erik Joelsson
erikj at openjdk.org
Thu Feb 15 14:05:12 UTC 2024
On Thu, 15 Feb 2024 12:26:11 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us getting files in the repository that would not be accepted by jcheck. This can happen when extending the set of files checked by jcheck, or if jcheck changes how it checks files (perhaps due to bug fixes).
>>
>> I have now run jcheck over the entire code base, and fixed a handful of issues. With these changes, jcheck accept the entire code base.
>
> test/jdk/java/util/Currency/currency.properties line 18:
>
>> 16: SB=EUR,111,2, 2099-01-01T00:00:00
>> 17: US=euR,978,2,2001-01-01T00:00:00
>> 18: ZZ = ZZZ , 999 , 3
>
> This looks weird, but so did the original code. I assume this is to clearly indicate this as a end of list marker.
This looks weird indeed. Luckily it's just test code. Did you run the test after this change?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17871#discussion_r1491056108
More information about the build-dev
mailing list