RFR: 8325878: Require minimum Clang version 13

Thomas Stuefe stuefe at openjdk.org
Fri Feb 16 05:23:54 UTC 2024


On Fri, 16 Feb 2024 04:46:24 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> > Unfortunately this will break my workflow on Linux - I use clang to build on Ubuntu 20.04, which is not that old, but it ships with clang 12. This is not a deal breaker, just annoying.
> 
> That's unfortunate, but I think the [[noreturn]] issue is very important. Until we have that fix, we can't rely on that attribute to silence certain warnings. This requires us to continue to insert dead returns or apply other workarounds. And forgetting to do so (because someone makes a change that works fine with later versions or on other platforms) will lead to build-breakage JBS issues/PRs just to continue to support older versions of clang. We've already had several of those.

Thank you for explaining the motivation. @forax also mentioned that our workaround produces false warnings in IDEs (just checked in CDT). I'm fine with it - I will find another solution for my Linux box.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17862#issuecomment-1947776707


More information about the build-dev mailing list