RFR: 8325963: Clean up NativeCompilation.gmk and its newly created parts [v2]

[Magnus Ihse Bursie]

On Tue, 20 Feb 2024 17:13:12 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clarify comment based on review
>
> make/common/NativeCompilation.gmk line 132:
> 
>> 130: SetupNativeCompilation = $(NamedParamsMacroTemplate)
>> 131: define SetupNativeCompilationBody
>> 132:   # In this functions, helpers named Setup<Foo> are just setting variables.
> 
> Suggestion:
> 
>   # In this function, helpers named Setup<Foo> are just setting variables.
> 
> I think have tried to use the word "macro" rather than "function" in makefiles as that's what they technically are.

I was on the fence for this one. I know they are macros, but we use them like functions. But sure, I'll go with technically correct (after all, it's [the best kind of correct](https://www.youtube.com/watch?v=0ZEuWJ4muYc)).

> make/common/native/Paths.gmk line 195:
> 
>> 193: 
>> 194: ################################################################################
>> 195: define RemoveSuperfluousOutputFiles
> 
> This macro doesn't fit in either of the two categories mentioned at the top. Perhaps worth clarifying that it's different here. It performs direct actions on output files but also doesn't do it through a recipe.

I left out the third category of macros that are neither Setup nor Create, since they can do all kind of strange stuff. But now I added a comment about it; hope you feel it's enough.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17873#discussion_r1496315088
PR Review Comment: https://git.openjdk.org/jdk/pull/17873#discussion_r1496316773