RFR: 8325963: Clean up NativeCompilation.gmk and its newly created parts [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Tue Feb 20 19:02:12 UTC 2024
On Tue, 20 Feb 2024 18:49:22 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Clarify comment based on review
>
> make/common/NativeCompilation.gmk line 132:
>
>> 130: SetupNativeCompilation = $(NamedParamsMacroTemplate)
>> 131: define SetupNativeCompilationBody
>> 132: # In this functions, macros named Setup<Foo> are just setting variables.
>
> "functions" is still grammatically wrong. Do you actually mean "this macro", "these macros" or "this file"? I think there were a couple of other mentions of "function" further down as well.
Better now?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17873#discussion_r1496346965
More information about the build-dev
mailing list