RFR: 8017234: Hotspot should stop using mapfiles

[Julian Waters]

On Thu, 22 Feb 2024 10:15:54 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Ah, I should have clarified that I did read the explaination, just that it slipped my mind at the time. I can't remember if C++14 or C++17 is the version for compilers ignoring unknown attributes though
>> 
>> Also, you can escape the underscores with \ to avoid GitHub formatting. GitHub can get annoying with its formatting sometimes
>> 
>> Is there a chance this can be fixed in a followup somehow? I could help with that, given I have access to WSL2 for Linux
>
> You mean making a search/replace from `__attribute__ ((foo))` to `[[gnu::foo)]]` in the code base? It seems a bit like unnecessary churn to me. We have 100+ places in the code with `__attribute__`. If you really want to try to push that agenda, be my guest. But do it in a separate PR. ;-)

Oh no, by fix I meant removing the HIDDEN attribute and somehow fixing that issue differently, not replacing everything with C++ Attributes!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17955#discussion_r1499004595