RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234
David Holmes
dholmes at openjdk.org
Thu Feb 22 22:25:54 UTC 2024
On Thu, 22 Feb 2024 16:28:20 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> Once [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) has been integrated, it is possible to do some cleanup. The goal of [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) was to not change any behavior, even if that behavior seemed odd.
>
> Now let's try to fix that. We can:
>
> a) remove JNIEXPORT from c2v functions.
> b) make debug.cpp functions exported similarly on all platforms.
> c) remove JNIEXPORT from aarch64 asm debug function.
>
> Note that this PR is [dependent on](https://mail.openjdk.org/pipermail/jdk-dev/2021-March/005232.html) https://github.com/openjdk/jdk/pull/17955.
With the one exception above I agree with these choices going forward. I don't think it matters that exporting for the debugger is not actually necessary on some platforms, and so code simplicity wins out for me. That said the litmus test will be whether hermetic Java encounters any conflicts.
Thanks
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17967#issuecomment-1960427179
More information about the build-dev
mailing list