RFR: 8326587: Separate out Microsoft toolchain linking

Julian Waters jwaters at openjdk.org
Sat Feb 24 06:23:13 UTC 2024


On Fri, 23 Feb 2024 22:05:44 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> And then I think this will actually help Julian, since we'll push the microsoft strangeness away in a separate file

Thanks! Though I do first need to rebase on top of it and fix all the merge conflicts first...
(Thinking about it, this likely means I have to excise some of the Microsoft linking logic out into the "regular" linking file since some of the Microsoft linking process is used by Windows linking in general, even with the gcc toolchain)

Just a comment: Why not reuse the AR variable for lib rather than introduce an entirely new LIB variable? The logic treating lib.exe as ar is gone with this change, but that doesn't mean they have to be split into entirely different variables. LinkMicrosoft could just run $($1_AR) without treating it as ar. This saves one autoconf and Makefile variable

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17987#issuecomment-1962272988


More information about the build-dev mailing list