RFR: 8174269: Remove COMPAT locale data provider from JDK [v2]

Naoto Sato naoto at openjdk.org
Mon Feb 26 21:32:22 UTC 2024


On Mon, 26 Feb 2024 16:39:29 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Actually, as the file currently in the PR, it does not seem like it does anything at all, since we no longer create `_the.locale_resources`. Or... hm, without that file, `PREV_LOCALE_RESOURCES` will always be empty. I wonder what `$(filter-out $(PREV_LOCALE_RESOURCES), $(LOCALE_RESOURCES))` returns in that case. If it is empty, then this file does nothing. If it is `$(LOCALE_RESOURCES)`, then we will unconditionally rm the two files.
>> 
>> I believe the original intention was to spot added or removed locale resources, and use that to trigger a re-generation. This does not seem to work at all anymore. Do we still need that kind of behavior?
>
> Oh, this is a rabbit hole. :-( 
> 
> I tried to figure out where `CLDRBaseLocaleDataMetaInfo.java` comes from; I could not see where we generated that file. Turns out it is created in `make/jdk/src/classes/build/tools/cldrconverter/ResourceBundleGenerator.java`, in the function `generateMetaInfo()`. I assume this is called as part of calling the CLDRConverter buildtool. But this is done in `make/modules/[java.base|jdk.localedata]/Gensrc.gmk`. So if we need to invalidate that build tool result, it should be done in these files.

Thanks. Good points.
As CLDR tool generates those files, `GensrcLocaleData.gmk` no longer seems necessary. I will remove it after I do some testings.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17991#discussion_r1503323383


More information about the build-dev mailing list