RFR: 8326685: Linux builds not reproducible if two builds configured in different build folders

[Andrew Leonard]

On Mon, 26 Feb 2024 22:05:34 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> I have not thought this fully through, but just throwing out a question: would this work even if one build directory were inside the workspace root, and the other not?
>
> Oh you are right, we should always add the OUTPUTDIR to both maps regardless of if it's internal to the WORKSPACE_ROOT or not. Paths relative to the OUTPUTDIR should be stable across builds in different output directories, but paths inside the OUTPUTDIR, expressed as relative to the WORKSPACE_ROOT will vary.

> I have not thought this fully through, but just throwing out a question: would this work even if one build directory were inside the workspace root, and the other not?

Yes, I have tested that scenario as well, and does work. It was in fact the scenario in which I discovered the problem in the first place.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18009#discussion_r1503805898