RFR: 8326685: Linux builds not reproducible if two builds configured in different build folders [v2]

Magnus Ihse Bursie ihse at openjdk.org
Tue Feb 27 12:02:52 UTC 2024


On Tue, 27 Feb 2024 11:50:35 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

>> Also, this mapping business is getting really convoluted. :-( I did not like it as it was, and this patch makes it even worse. I think we need to rewrite this to create some kind of dict/map, and then iterate over the map and apply `-fdebug-prefix-map` to all items in the map. Unfortunately, the data structures available in shell scripts is limited and will make this a bit tricky to pull off. :(
>
> @magicus thank you for the tip, it works nicely, ready for re-review please

Looks good to me now, but please let Erik have a look as well before pushing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18009#discussion_r1504114547


More information about the build-dev mailing list