RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v4]

Andrew Dinn adinn at openjdk.org
Tue Feb 27 16:13:54 UTC 2024


On Tue, 27 Feb 2024 15:35:56 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> It does not sound like anyone object to the removal of `JNIEXPORT` for `das1`, then.
>> 
>> Or should I just remove the entire function, if it serves no purpose that any current maintainers know or care about?
>
> You can probably remove the entire function given it's an indirection to `das` anyway. I remember using it for debugging during the first stages of the Windows-AArch64 port but I've long forgotten about it.

@luhenry @magicus das1 was added when we were implementing the AArch64 port in order to help us integrate the debugger support we provided when running JITted code on our AArch64 simulator into gdb. Now that we have real hardware it is redundant.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17967#discussion_r1504535787


More information about the build-dev mailing list