RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v5]

Brian Stafford bstafford at openjdk.org
Tue Feb 27 22:06:52 UTC 2024


On Fri, 23 Feb 2024 12:03:37 GMT, Bernhard Urban-Forster <burban at openjdk.org> wrote:

>> Instead of discussing removal of windows/aarch64 (although the general rule in OpenJDK is that ports that are not maintained by anyone should be removed); let's stick to the question here: do we need to export `das1()` for debugging?
>
> Personally I have never used `das`/`das1` on any AArch64 port when debugging.  I guess it was somewhat handy when the backend was originally developed.  I would argue that the built-in disassembler of any debugger and `disnm` from `debug.cpp` are good enough, and thus `das`/`das1` can be removed.  What do you think @theRealAph ?

Removal makes sense - thank you @lewurm, @luhenry, and @adinn for your input!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17967#discussion_r1505070224


More information about the build-dev mailing list