RFR: 8326831 Clarify test harness control variables in make help

[Guoxiong Li]

On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:

> Clarifying text in `make help` output on how to list variables for e.g. JTREG='...'.

I use the command `make test-only JTREG=help` locally, the outputed message seems an error (shown below). Does it work as expected?


Building target 'test-only' in configuration 'linux-x86_64-server-fastdebug'
Valid keywords for JTREG:
RunTests.gmk:205: *** Re-run without 'help' to continue.  Stop.
JOBS TIMEOUT_FACTOR FAILURE_HANDLER_TIMEOUT TEST_MODE ASSERT VERBOSE RETAIN TEST_THREAD_FACTORY MAX_MEM RUN_PROBLEM_LISTS RETRY_COUNT REPEAT_COUNT MAX_OUTPUT REPORT OPTIONS JAVA_OPTIONS VM_OPTIONS KEYWORDS EXTRA_PROBLEM_LISTS LAUNCHER_OPTIONS.
gmake[2]: *** [make/Main.gmk:797: test] Error 2

ERROR: Build failed for target 'test-only' in configuration 'linux-x86_64-server-fastdebug' (exit code 2) 

No indication of failed target found.
HELP: Try searching the build log for '] Error'.
HELP: Run 'make doctor' to diagnose build problems.

make[1]: *** [/home/lgx/source/java/fast-jdk/make/Init.gmk:323: main] Error 2
make: *** [/home/lgx/source/java/fast-jdk/make/Init.gmk:189: test-only] Error 2


The location of the `RunTests.gmk:205: *** Re-run without 'help' to continue.  Stop.` is wrong. But it sometimes works good (Shown below).


Building target 'test-only' in configuration 'linux-x86_64-server-fastdebug'
Valid keywords for JTREG:
JOBS TIMEOUT_FACTOR FAILURE_HANDLER_TIMEOUT TEST_MODE ASSERT VERBOSE RETAIN TEST_THREAD_FACTORY MAX_MEM RUN_PROBLEM_LISTS RETRY_COUNT REPEAT_COUNT MAX_OUTPUT REPORT OPTIONS JAVA_OPTIONS VM_OPTIONS KEYWORDS EXTRA_PROBLEM_LISTS LAUNCHER_OPTIONS.
RunTests.gmk:205: *** Re-run without 'help' to continue.  Stop.
gmake[2]: *** [make/Main.gmk:797: test] Error 2

ERROR: Build failed for target 'test-only' in configuration 'linux-x86_64-server-fastdebug' (exit code 2) 

No indication of failed target found.
HELP: Try searching the build log for '] Error'.
HELP: Run 'make doctor' to diagnose build problems.

make[1]: *** [/home/lgx/source/java/fast-jdk/make/Init.gmk:323: main] Error 2
make: *** [/home/lgx/source/java/fast-jdk/make/Init.gmk:189: test-only] Error 2

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18028#issuecomment-1968862420