RFR: 8326953: Possible race in creation of win-exports.def

[Julian Waters]

On Wed, 28 Feb 2024 12:26:54 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> We have seen a build failure along the lines of:
> 
>  /usr/bin/mv: cannot move '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' to '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def': No such file or directory
> 
> on Windows.
> 
> My guess is that this is a race between creating the win-export.def file for the gtest jvm and the product jvm.

Marked as reviewed by jwaters (Committer).

Marked as reviewed by jwaters (Committer).

make/hotspot/lib/CompileJvm.gmk line 151:

> 149:   WIN_EXPORT_FILE := $(JVM_OUTPUTDIR)/win-exports.def
> 150: 
> 151:   JVM_LDFLAGS_NO_GTEST += -def:$(WIN_EXPORT_FILE)

Can't this just be named EXPORT_FILE_FLAG or something along those lines? LDFLAGS_NO_GTEST seems a bit strange

-------------

PR Review: https://git.openjdk.org/jdk/pull/18043#pullrequestreview-1906237581
PR Review: https://git.openjdk.org/jdk/pull/18043#pullrequestreview-1906240849
PR Review Comment: https://git.openjdk.org/jdk/pull/18043#discussion_r1505943413