RFR: 8326953: Race in creation of win-exports.def with static-libs [v3]

[David Holmes]

On Wed, 28 Feb 2024 17:06:17 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> We have seen a build failure along the lines of:
>> 
>>  /usr/bin/mv: cannot move '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' to '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def': No such file or directory
>> 
>> on Windows.
>> 
>> My guess is that this is a race between creating the win-export.def file for the gtest jvm and the product jvm.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Also restore newline
>  - Roll back gtest changes

Seems reasonable. Thanks for jumping on this so quick!

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18043#pullrequestreview-1907474544