RFR: 8274300: Address dsymutil warning by excluding platform specific files

Erik Joelsson erikj at openjdk.org
Fri Jan 5 23:30:20 UTC 2024


On Fri, 5 Jan 2024 21:05:49 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

> When building on macOS, dsymutil generates a warning for some files:
> 
> `warning: no debug symbols in executable (-arch x86_64)`
> 
> It turns out that the files in question have one thing in common: they're empty. Specifically, the source files have include guards which, on macOS, end up excluding all the actual source code, leaving an effectively empty source file and hence empty object file.
> 
> This change excludes the relevant files from the builds/platforms where they're not needed.
> 
> Testing: tier1,builds-tier[2-5]

Excluding test files in the makefiles is the current preferred way of handling platform specific tests rather than preprocessor conditionals, so this is the right thing to do.

-------------

Marked as reviewed by erikj (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17287#pullrequestreview-1807078622


More information about the build-dev mailing list