RFR: 8274300: Address dsymutil warning by excluding platform specific files

Mikael Vidstedt mikael at openjdk.org
Mon Jan 8 19:34:22 UTC 2024


On Mon, 8 Jan 2024 02:41:29 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> When building on macOS, dsymutil generates a warning for some files:
>> 
>> `warning: no debug symbols in executable (-arch x86_64)`
>> 
>> It turns out that the files in question have one thing in common: they're empty. Specifically, the source files have include guards which, on macOS, end up excluding all the actual source code, leaving an effectively empty source file and hence empty object file.
>> 
>> This change excludes the relevant files from the builds/platforms where they're not needed.
>> 
>> Testing: tier1,builds-tier[2-5]
>
> make/test/JtregNativeHotspot.gmk line 862:
> 
>> 860: ifeq ($(call And, $(call isTargetOs, linux) $(call isTargetCpu, aarch64)), false)
>> 861:   BUILD_HOTSPOT_JTREG_EXCLUDE += libTestSVEWithJNI.c
>> 862: endif
> 
> I would have put this inside the existing Linux section  ie move to before the endif at line 858, and then just check for aarch64.

It's the other way around - this test is excluded for all platforms _but_ linux-aarch64 (note the `false`).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17287#discussion_r1445235539


More information about the build-dev mailing list